Reuse and extend standardized OCI annotations #299
+184
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotTheEvilOne
force-pushed
the
feature/oci-annotations
branch
2 times, most recently
from
8026ec2 to
b7111df
Compare
Signed-off-by: Tobias Wolf <[email protected]> On-behalf-of: SAP <[email protected]>
NotTheEvilOne
force-pushed
the
feature/oci-annotations
branch
from
b7111df to
7031daa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 91.44% 91.76% +0.31%
==========================================
Files 42 42
Lines 2092 2136 +44
==========================================
+ Hits 1913 1960 +47
+ Misses 179 176 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yeoldegrove
requested changes
Feb 2, 2026
Contributor
yeoldegrove
left a comment
yeoldegrove
left a comment
There was a problem hiding this comment.
The feature looks fine to me. Just have a small question.
Comment on lines
+632
to
+644
| def upload_manifest(self, manifest: Manifest, container: OrasContainer) -> Response: | ||
| """ | ||
| oras-project.github.io: Read a manifest file and upload it. | ||
|
|
||
| :param manifest: manifest to upload | ||
| :param container: parsed container URI | ||
|
|
||
| :return: (object) OCI manifest put response | ||
| :since: 1.0.0 | ||
| """ | ||
|
|
||
| return Registry.upload_manifest(self, manifest.extended_dict, container) # type: ignore[no-any-return] | ||
|
|
Contributor
There was a problem hiding this comment.
Just a question: As this is a new function, does it mean that the current code is broken? If yes, please label this as a bugfix (e.g. in an extra commit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR extends generated OCI image manifests with more standardized annotations.